Upgrade Django and ensure compat with it #2651
Conversation
[noissue] (cherry picked from commit c06ed6d)
bmbouter
force-pushed
the
upgrade-django-to-2.2.28
branch
from
eb90a37
to
05b3e95
Compare
Required PR: pulp/pulpcore#2651 closes pulp#744
There was a problem hiding this comment.
This change does not suffice for container plugin pulp/pulp_container#745 (comment)
https://github.com/pulp/pulp_container/runs/6271437401?check_suite_focus=true#step:14:399
|
We're going to wait and see if those using 3.7 are aware that even after fixing this they will be using an unsupported version of Django. If they still want us to release the fixes we'll have to evaluate all plugins (like pulp_container) and likely release several fixes. So we're waiting for now to see what is best. |
Required PR: pulp/pulpcore#2651 closes pulp#744
Required PR: pulp/pulpcore#2651 closes pulp#744
Required PR: pulp/pulpcore#2651 closes pulp#744
Required PR: pulp/pulpcore#2651 closes pulp#744
Required PR: pulp/pulpcore#2651 closes pulp#744
Required PR: pulp/pulpcore#2651 closes pulp#744
Required PR: pulp/pulpcore#2651 closes pulp#744
| @@ -3,7 +3,7 @@ aiodns | |||
| aiofiles | |||
| backoff | |||
| click<8 | |||
| Django~=2.2.16 # LTS version, switch only if we have a compelling reason to | |||
There was a problem hiding this comment.
@bmbouter I think we actually don't even need this PR. Means that we also don't need to release pulpcore 3.7
once pulp-container 2.1 is released with this change https://github.com/pulp/pulp_container/pull/745/files i think we are good to go.
There was a problem hiding this comment.
Yeah I think you are right. I'll close the pulpcore PR w/ a similar comment.
There was a problem hiding this comment.
Oh ha, this is on that very PR. Closing!
Required PR: pulp/pulpcore#2651 closes #744
[noissue]
(cherry picked from commit c06ed6d)