Extend the interface of verify_signature #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 5, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 5, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 5, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 5, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
force-pushed
the
verify_signature
branch
5 times, most recently
from
913dee2
to
a2d5b04
Compare
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 6, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 6, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 6, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 7, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 7, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 7, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 8, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 12, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
mdellweg
force-pushed
the
verify_signature
branch
from
a2d5b04
to
542eee1
Compare
mdellweg
added a commit
to mdellweg/pulp_ansible
that referenced
this pull request
Jul 12, 2022
fixes pulp#1086 Required PR: pulp/pulpcore#2931
gerrod3
approved these changes
Jul 12, 2022
mdellweg
force-pushed
the
verify_signature
branch
from
542eee1
to
87b068c
Compare
bmbouter
reviewed
Jul 13, 2022
pulpcore/app/util.py
Outdated
|
|
||
| verified = gpg.verify_file(signature, detached_data) | ||
| if not verified.valid: | ||
| raise InvalidSignatureError("The signature is not valid.", verified=verified) |
There was a problem hiding this comment.
Is this a user-facing string, if so should it be i18n with gettext?
There was a problem hiding this comment.
I think, yes, it could be.
This function accepts both the signature as well as the (detached) signed data as paths, artifacts or file-like objects. Also deprecate verify_signature. fixes pulp#2930
mdellweg
force-pushed
the
verify_signature
branch
from
87b068c
to
2b84122
Compare
bmbouter
approved these changes
Jul 13, 2022
|
Thanks @mdellweg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2930