Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pulpcore-plugin into pulpcore as a subpackage #347

Merged
merged 5 commits into from
Oct 28, 2019
Merged

Move pulpcore-plugin into pulpcore as a subpackage #347

merged 5 commits into from
Oct 28, 2019

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Oct 22, 2019

@dralley dralley force-pushed the move-pulpcore-plugin branch 4 times, most recently from 3d272d0 to 7b01dbd Compare October 22, 2019 22:05
dralley added a commit to dralley/pulp_file that referenced this pull request Oct 22, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
740600d 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_file that referenced this pull request Oct 22, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
1221f44 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_rpm that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
c72b493 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
@dralley dralley mentioned this pull request Oct 23, 2019
Merged
dralley added a commit to dralley/pulp_rpm that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
b4ca952 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
@dralley dralley mentioned this pull request Oct 23, 2019
Merged
dralley added a commit to dralley/pulp_ansible that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
b12989b 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
@dralley dralley mentioned this pull request Oct 23, 2019
Merged
dralley added a commit to dralley/pulp_python that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
4a6a86e 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_python that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
c896d65 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
@dralley dralley mentioned this pull request Oct 23, 2019
Merged
dralley added a commit to dralley/pulp_maven that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
8c5ebfe 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
@dralley dralley mentioned this pull request Oct 23, 2019
Merged
dralley added a commit to dralley/pulp_maven that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
cc7aa25 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_python that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
b8b5b89 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_ansible that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
3c285bb 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_maven that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
dd3501e 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_python that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
1e24c7a 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_rpm that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
27dbddd 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_maven that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
3f100f4 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_maven that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
f4b86e5 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
dralley added a commit to dralley/pulp_ansible that referenced this pull request Oct 23, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
2fa1b74 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
bmbouter
bmbouter reviewed Oct 24, 2019
View reviewed changes
pulpcore/stages/test_artifactdownloader.py Outdated
@@ -0,0 +1,364 @@
import asyncio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these test_files are in the code base itself, but I expected them inpulpcore/tests` https://github.com/pulp/pulpcore/tree/master/pulpcore/tests There should likely be both unit and functional tests. Also I checked Travis and they are not running there. The Travis tests need to pass with these the pulpcore-plugin tests also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dralley dralley force-pushed the move-pulpcore-plugin branch 16 times, most recently from 768e1f9 to b044dc6 Compare October 28, 2019 14:22
dralley added a commit to dralley/pulp_maven that referenced this pull request Oct 28, 2019
@dralley
Depend on pulpcore directly instead of pulpcore-plugin
196425b 
Required PR: pulp/pulpcore#347

re: #5580
https://pulp.plan.io/issues/5580
bmbouter
bmbouter reviewed Oct 28, 2019
View reviewed changes
pulpcore/plugin/__init__.py Outdated
@@ -0,0 +1,7 @@
__version__ = '0.1.0rc8.dev'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we will not have another version number for this package. We had talked about doing that, but since we couldn't depend on it with setuptools, we can just use pulpcore. For example with the changelog, we'll add custom towncrier extensions which will build two "sections" of the changelog, one for users, one for plugin writers. Both would use the version of pulpcore itself though (not this one). @daviddavis @dralley @dkliban does this sound right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a big PR though I'm in favor of merging as-is and fixing in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds right to be based on my memory of our discussion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly as I remember it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line deleted

bmbouter
bmbouter approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's merge and we can make additional improvements afterwards. Thanks @dralley ! 💯

dralley added a commit to dralley/pulp_installer that referenced this pull request Oct 28, 2019
@dralley
Update Travis config for the removal of pulpcore-plugin
133e935 
Required PR: pulp/pulpcore#347

re: #5580
ihttps://pulp.plan.io/issues/5580
@dralley dralley merged commit 1e25989 into pulp:master Oct 28, 2019
@dralley dralley deleted the move-pulpcore-plugin branch October 28, 2019 16:04
mikedep333 pushed a commit to mikedep333/pulp_installer that referenced this pull request Nov 8, 2019
@dralley @mikedep333
Update Travis config for the removal of pulpcore-plugin
f7f5b0b 
Required PR: pulp/pulpcore#347

re: #5580
ihttps://pulp.plan.io/issues/5580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddavis daviddavis daviddavis left review comments

@dkliban dkliban dkliban left review comments

@bmbouter bmbouter bmbouter approved these changes

Assignees
No one assigned
Labels
Breaking Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dralley @daviddavis @bmbouter @dkliban