Fix invalid date-time field format in PurgeSerializer

[jerabekjiri]

fixes: #3585

Galaxy_ng integration tests fail with invalid openapi format, I'm not really sure why it started showing now

=================================== FAILURES ===================================
________________________ test_galaxy_openapi_validation ________________________
galaxy_ng/tests/integration/api/test_openapi.py:65: in test_galaxy_openapi_validation
    validate_spec(galaxy_spec)
/tmp/gng_testing/lib/python3.10/site-packages/openapi_spec_validator/shortcuts.py:17: in validate_spec
    return validator.validate(spec, spec_url=spec_url)
/tmp/gng_testing/lib/python3.10/site-packages/openapi_spec_validator/validation/proxies.py:28: in validate
    raise err
E   openapi_spec_validator.validation.exceptions.OpenAPIValidationError: '2023-01-14' is not a 'date-time'
E   
E   Failed validating 'format' in schema:
E       {'default': '2023-01-14',
E        'description': 'Purge tasks completed earlier than this timestamp. '
E                       "Format '%Y-%m-%d[T%H:%M:%S]'",
E        'format': 'date-time',
E        'type': 'string'}
E   
E   On instance:
E       '2023-01-14'
=========================== short test summary info ============================
FAILED galaxy_ng/tests/integration/api/test_openapi.py::test_galaxy_openapi_validation - openapi_spec_validator.validation.exceptions.OpenAPIValidationError: '2023-01-14' is not a 'date-time'

[jerabekjiri]

CI test fails on

Exception in thread "main" java.lang.RuntimeException: Could not process model 'Purge'.Please make sure that your schema is correct!
  	at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:496)
  	at org.openapitools.codegen.DefaultGenerator.generate(DefaultGenerator.java:1005)
  	at org.openapitools.codegen.cmd.Generate.execute(Generate.java:431)
  	at org.openapitools.codegen.cmd.OpenApiGeneratorCommand.run(OpenApiGeneratorCommand.java:32)
  	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:61)
  Caused by: java.lang.ClassCastException: java.time.OffsetDateTime cannot be cast to java.lang.String
  	at org.openapitools.codegen.languages.PythonClientCodegen.toExampleValueRecursive(PythonClientCodegen.java:724)
  	at org.openapitools.codegen.languages.PythonClientCodegen.toExampleValue(PythonClientCodegen.java:703)
  	at org.openapitools.codegen.DefaultCodegen.fromProperty(DefaultCodegen.java:2846)
  	at org.openapitools.codegen.DefaultCodegen.addVars(DefaultCodegen.java:4534)
  	at org.openapitools.codegen.DefaultCodegen.addVars(DefaultCodegen.java:4482)
  	at org.openapitools.codegen.DefaultCodegen.fromModel(DefaultCodegen.java:2[378](https://github.com/pulp/pulpcore/actions/runs/4224067517/jobs/7334573002#step:8:379))
  	at org.openapitools.codegen.DefaultGenerator.processModels(DefaultGenerator.java:1289)
  	at org.openapitools.codegen.DefaultGenerator.generateModels(DefaultGenerator.java:491)
  	... 4 more
  Error: Process completed with exit code 1. 

error java.time.OffsetDateTime cannot be cast to java.lang.String seems like bug in openapi-generator 4.3.1 and is fixed in version >=5.0.0 (OpenAPITools/openapi-generator#6694)

similar issue: OpenAPITools/openapi-generator#6433
fix PR: OpenAPITools/openapi-generator#6458

so I think it would be worth upgrading python bindings https://github.com/pulp/pulp-openapi-generator/blob/da6a6568aa8da3d57bfd2bdc2954e09144d154dd/generate.sh#L74

[stale]

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

[ipanova]

@jerabekjiri what's the plan with PR?close or?

[stale]

This issue is no longer marked for closure.

[jerabekjiri]

@ipanova so in order to unblock this PR and revert ansible/galaxy_ng#1616, docker.io/openapitools/openapi-generator-cli has to be bumped to version >=5.0.0 (https://github.com/pulp/pulp-openapi-generator/blob/30e72b6337e65b748deaf4e14b49469d64e80d73/generate.sh#L75)

I reproduced it locally and bumping the version fixed the error.

[dkliban]

Let's close this PR and focus on upgrading pulp-openapi-generator to use openapi-generator-cli 6+