Handling write_only fields on OpenAPISchema #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
changed the title
fao89
force-pushed
the
5622
branch
3 times, most recently
from
77e45ff
to
b032fd0
Compare
fao89
changed the title
fao89
commented
Mar 19, 2020
| if self.method.lower() == "get": | ||
| new_fields = OrderedDict() | ||
| for field_name, field in serializer.fields.items(): | ||
| if not field.write_only: # Removing write_only fields |
There was a problem hiding this comment.
@daviddavis this PR is half of the patch linked above, it is the equivalent to ReadOnlySerializer from that patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/5622
closes #5622
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html