Fix 500 error on parallel same-object creates #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
approved these changes
Aug 2, 2023
mdellweg
reviewed
Aug 2, 2023
gerrod3
force-pushed
the
parallel-same-creates
branch
from
a4ff20e
to
43a7bc8
Compare
dkliban
approved these changes
Aug 2, 2023
|
Thanks @gerrod3 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4183
Not sure how to write a test for this. I manually tested this with
Roughly 1 in 3 attempts will fail with a 500 error, this fixes the race condition and will give a nice 400 error.
@jlsherrill Interestingly you found this bug when creating domains, but it actually affects all immediate-creation objects in Pulp. 馃槷