Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow whitespace and comments in db key file #4516

Merged
merged 1 commit into from Oct 17, 2023
Merged

Allow whitespace and comments in db key file #4516

merged 1 commit into from Oct 17, 2023

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Oct 2, 2023 •
edited

fixes #4542

@mdellweg mdellweg marked this pull request as ready for review October 2, 2023 13:56
@dralley
Copy link
Contributor

dralley commented Oct 3, 2023

I understand allowing whitespace, but why comments? This should probably have an issue with additional explanation

@mdellweg
Copy link
Member Author

mdellweg commented Oct 4, 2023

I understand allowing whitespace, but why comments? This should probably have an issue with additional explanation

Whitespace was triggered by this: https://discourse.pulpproject.org/t/pulp-minimal-3-35-pulp-api-metadata-signing-service-http-1-1-500-internal-server-error/1002/5

Comments were like "why not". And my thinking is: You can specify multiple keys in there (to allow key rotation.) Adding comments which key is supposed to be the new one and must move to the top of the list eventually or even a note when it's supposed to happen may become priceless.

ipanova
ipanova reviewed Oct 11, 2023
View reviewed changes
CHANGES/+db_encryption.feature Outdated
@@ -0,0 +1 @@
Parsing of the db encryption key was made resiliant to whitespace and to allow comments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you file an issue so the changelog is in the format of XXXX.feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I wanted to know if we would accept this as a feature...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any step towards making things more resilient is a good step, I think.

@mdellweg mdellweg merged commit 8681553 into pulp:main Oct 17, 2023
14 checks passed
@mdellweg mdellweg deleted the fernet_parsing branch October 17, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipanova ipanova ipanova approved these changes

@ggainey ggainey ggainey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow whitespace and comments in db key file
4 participants
@mdellweg @dralley @ipanova @ggainey