Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose batch_qs to plugin API #4627

Merged
merged 1 commit into from Nov 2, 2023
Merged

Conversation

quba42
Copy link
Contributor

@quba42 quba42 commented Oct 31, 2023

closes #4607

@quba42 quba42 marked this pull request as ready for review October 31, 2023 15:07
@quba42
Copy link
Contributor Author

quba42 commented Oct 31, 2023

Looks like the docs don't like the docstring of batch_qs:

Warning, treated as error:
/home/runner/work/pulpcore/pulpcore/pulpcore/plugin/util.py:docstring of pulpcore.app.util.batch_qs:7:Unexpected indentation.

I will have a look.

@quba42
Copy link
Contributor Author

quba42 commented Oct 31, 2023

Not sure what happened to the tests.

@mdellweg
Copy link
Member

Not sure what happened to the tests.

Me neither. Just that it started this morning. Rebasing now should fix it.

Copy link
Member

@lubosmj lubosmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix typos. We will merge it afterwards.

pulpcore/app/util.py Outdated Show resolved Hide resolved
CHANGES/plugin_api/4607.feature Outdated Show resolved Hide resolved
@quba42
Copy link
Contributor Author

quba42 commented Nov 2, 2023

@lubosmj Thanks for checking my at times atrocious spelling!

@mdellweg mdellweg merged commit 268fc3a into pulp:main Nov 2, 2023
14 checks passed
@quba42 quba42 deleted the expose_batch_qs branch November 2, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose batch_qs() to the plugin API
3 participants