New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libeatmydata to speed up travis #467
Conversation
@fabricio-aguiar am I reading correctly that this did not reduce the Travis runtime? |
yes, I just opened this PR to be a record that it did not improve travis performance |
@fabricio-aguiar thank you. Want to close this PR and also the associated Redmine issue? |
Does not seem to be effective |
Also, I think this small commit would only speed up travis a little bit, so be careful when analyzing results. We'd have to put that code block in more scripts that have disk I/O. And any code running in containers would need implementation as well. It might be best to do initial performance testing by doing a travis debug in your own fork. (Of course, this may all be for nothing if travis is already doing the equivalent of libeatmydata at the hypervisor level.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment on code, and in the main convo.
export LD_PRELOAD='/usr/lib/libeatmydata/libeatmydata.so' | ||
elif [ -r /usr/lib/*/libeatmydata.so ]; then | ||
# much faster package installation | ||
export LD_PRELOAD='/usr/$LIB/libeatmydata.so' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not reviewing this earlier.
Is $LIB actually set? I just ran docker containers for ubuntu:xenial & ubuntu:bionic, and it was not.
We can also just hardcode the Ubuntu/Debian x86_64 path for now:
export LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libeatmydata.so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was not set, I made some changes, but performance still pretty similar:
https://travis-ci.com/fabricio-aguiar/pulpcore/builds/146811533
code:
master...fabricio-aguiar:5871
got the USE_CHROOT from here:
https://github.com/sunny11mind/NumPy/blob/b48dc92402b1e928b6dc26214ca6ae6d445d50dd/.travis.yml#L16-L17
Does not seem to be effective
https://pulp.plan.io/issues/5871
closes #5871
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html