Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libeatmydata to speed up travis #467

Closed
wants to merge 1 commit into from
Closed

Use libeatmydata to speed up travis #467

wants to merge 1 commit into from

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Dec 27, 2019

Does not seem to be effective
https://pulp.plan.io/issues/5871
closes #5871

Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html

@bmbouter
Copy link
Member

@fabricio-aguiar am I reading correctly that this did not reduce the Travis runtime?

@fao89
Copy link
Member Author

fao89 commented Jan 21, 2020

@fabricio-aguiar am I reading correctly that this did not reduce the Travis runtime?

yes, I just opened this PR to be a record that it did not improve travis performance

@bmbouter
Copy link
Member

@fabricio-aguiar thank you. Want to close this PR and also the associated Redmine issue?

@fao89
Copy link
Member Author

fao89 commented Jan 21, 2020

Does not seem to be effective

@fao89 fao89 closed this Jan 21, 2020
@mikedep333
Copy link
Member

Also, I think this small commit would only speed up travis a little bit, so be careful when analyzing results. We'd have to put that code block in more scripts that have disk I/O. And any code running in containers would need implementation as well.

It might be best to do initial performance testing by doing a travis debug in your own fork.

(Of course, this may all be for nothing if travis is already doing the equivalent of libeatmydata at the hypervisor level.)

Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on code, and in the main convo.

export LD_PRELOAD='/usr/lib/libeatmydata/libeatmydata.so'
elif [ -r /usr/lib/*/libeatmydata.so ]; then
# much faster package installation
export LD_PRELOAD='/usr/$LIB/libeatmydata.so'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not reviewing this earlier.

Is $LIB actually set? I just ran docker containers for ubuntu:xenial & ubuntu:bionic, and it was not.

We can also just hardcode the Ubuntu/Debian x86_64 path for now:
export LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libeatmydata.so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants