Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced brief explanation about pulp_installer #688

Merged
merged 1 commit into from May 11, 2020
Merged

Conversation

fao89
Copy link
Member

@fao89 fao89 commented May 6, 2020

@pulpbot
Copy link
Member

pulpbot commented May 6, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 force-pushed the 6674 branch 2 times, most recently from 7cad671 to 8a6fb98 Compare May 6, 2020 19:52
content_origin: "http://{{ ansible_fqdn }}"
pulp_default_admin_password: password
pulp_install_plugins:
pulp-file: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does having all the plugins commented out here make sense to add in this example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it does, I will do it

@@ -154,7 +203,7 @@ Systemd
-------

To run the four Pulp services, systemd files needs to be created in /usr/lib/systemd/system/. The
`Pulp 3 Ansible Installer <https://github.com/pulp/pulp_installer/>`_ makes these for you, but you
`Pulp 3 Ansible Installer <https://github.com/pulp/pulp_installer/>`__ makes these for you, but you
Copy link
Member

@bmbouter bmbouter May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the motivation for adding the second underscore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulp 3 Ansible Installer <https://github.com/pulp/pulp_installer>__
appears 3 times in this doc,
Without the double underscore I got:

/home/travis/build/pulp/pulpcore/docs/installation/instructions.rst:2:Duplicate explicit target name: "pulp 3 ansible installer".
Makefile:55: recipe for target 'html' failed
make: *** [html] Error 2

https://travis-ci.com/github/pulp/pulpcore/jobs/328988703#L1248

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this solution from here:
https://stackoverflow.com/a/14067756

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I did not know about that. Thanks!

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmbouter bmbouter merged commit 304e580 into pulp:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants