Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return username and password when requesting Remote #695

Merged
merged 1 commit into from
May 11, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented May 8, 2020

https://pulp.plan.io/issues/6346
closes #6346

Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html

@pulpbot
Copy link
Member

pulpbot commented May 8, 2020

Attached issue: https://pulp.plan.io/issues/6346

@@ -0,0 +1 @@
Fixed: `Remote` fields `username` and `password` not showing up in REST docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe they were also not showing up in the openAPI schema definition

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean:
s/REST docs/openAPI schema

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to clarify it's not only affecting docs but also bindings. Also for changelogs I think we want to describe the solution to the problem not the problem itself. Put together, here's what that looks like to me:

Remote fields username and password show up in REST docs, API responses, and are available in the bindings.

How does this sound?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me per the open floor convo on Friday May 8. Thank you @fao89

I'd like to get another ack or two before we merge.

@bmbouter
Copy link
Member

With two acks and some IRC feedback I'm going to merge this. Thanks @fao89 !

@bmbouter bmbouter merged commit aadf1d6 into pulp:master May 11, 2020
@snecklifter
Copy link

@bmbouter @fao89 thanks for this, when can we expect to see this in a stable release?

@bmbouter
Copy link
Member

It will release with pulpcore 3.4.0. Yesterday on IRC I proposed tentative dates of May 19th or 26th. I'll bring up the 3.4.0 release timeline today at open floor today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants