Make ssl certs and keys accessible through RESTAPI #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6691 |
daviddavis
reviewed
May 12, 2020
CHANGES/6691.removal
Outdated
| @@ -0,0 +1 @@ | |||
| Removed SecretCharField from the codebase. | |||
There was a problem hiding this comment.
This probably needs to go in CHANGES/plugin_api.
There was a problem hiding this comment.
Oh, we never exposed it via the plugin api. Ignore 😺
There was a problem hiding this comment.
I did not see it exposed in the plugin api.
There was a problem hiding this comment.
I think it might be better to say here that fields that returned sha256 (ca_cert, client_cert, client_key) now return the full value.
daviddavis
reviewed
May 12, 2020
mdellweg
force-pushed
the
deprecate_secret_char_field
branch
from
b454dae
to
4435118
Compare
mdellweg
commented
May 12, 2020
mdellweg
commented
May 12, 2020
mdellweg
commented
May 12, 2020
mdellweg
force-pushed
the
deprecate_secret_char_field
branch
from
4bbe556
to
945e354
Compare
|
@mdellweg The code all looks good, my only suggestions are around the changelogs.
|
mdellweg
force-pushed
the
deprecate_secret_char_field
branch
from
945e354
to
c34a7ae
Compare
daviddavis
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6691
https://pulp.plan.io/issues/6691