Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version checking to import #710

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

daviddavis
Copy link
Contributor

fixes #6558

Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html

@ggainey
Copy link
Contributor

ggainey commented May 22, 2020

Looks good - if we decide to change how versions are checked, it's nicely isolated to one method. Merge away!

@pulpbot
Copy link
Member

pulpbot commented May 22, 2020

Attached issue: https://pulp.plan.io/issues/6558

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read for sanity and also am relying on the review from @ggainey . Thank you both!

@bmbouter bmbouter merged commit 8817d13 into pulp:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants