Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link from website update #757

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

melcorr
Copy link
Collaborator

@melcorr melcorr commented Jun 19, 2020

I updated the link to the Pulp 3 plugins that was out of date in the docs.

@pulpbot
Copy link
Member

pulpbot commented Jun 19, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@melcorr
Copy link
Collaborator Author

melcorr commented Jun 19, 2020

Actually, just spotted another few. Updating now.

@daviddavis
Copy link
Contributor

daviddavis commented Jun 19, 2020

I just noticed there is an issue for this. Can you replace [noissue] with fixes #7017 in your commit message?

@melcorr
Copy link
Collaborator Author

melcorr commented Jun 19, 2020

I should have checked for the issue. Thank you @daviddavis

@daviddavis
Copy link
Contributor

Oh, I forgot to mention you need to add a changelog entry too (ie CHANGES/7017.doc). More info:

https://docs.pulpproject.org/contributing/git.html#changelog-update

@daviddavis
Copy link
Contributor

And 'fixes' is case sensitive.

@melcorr
Copy link
Collaborator Author

melcorr commented Jun 19, 2020

Someday, I'll get it right :)

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daviddavis daviddavis merged commit 54871b6 into pulp:master Jun 19, 2020
@melcorr melcorr deleted the update-plugin-link branch June 19, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants