Fixed WorkerDirectory.delete() causing infinite recursion when permission errors occur #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6504 |
dralley
reviewed
Jul 9, 2020
pulpcore/tasking/services/storage.py
Outdated
| shutil.rmtree(self.path) | ||
| except FileNotFoundError: | ||
| pass | ||
| except PermissionError: |
There was a problem hiding this comment.
This isn't strictly necessary since it's just being raised afterwards -- it doesn't hurt anything though.
If you do decide to remove it, could you also move this method below the delete() method? Both of these are no big deal though.
…sion errors occur WorkerDirectory.delete() now only trys one additional time to delete its directory tree after encountering a PermissionError fixes #6504 https://pulp.plan.io/issues/6504
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkerDirectory.delete() now only tries one additional time to delete its directory tree after encountering a PermissionError
fixes #6504
https://pulp.plan.io/issues/6504