Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default DJANGO_SETTINGS_MODULE env var in content app #797

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Jul 21, 2020

This aligns the content service to the WSGI service (API) which already sets a default env var for DJANGO_SETTINGS_MODULE. By providing a default, the systemd service doesn't have to duplicate this and makes configuration easier.

fixes #7179

@pulpbot
Copy link
Member

pulpbot commented Jul 21, 2020

Attached issue: https://pulp.plan.io/issues/7179

@ekohl
Copy link
Contributor Author

ekohl commented Jul 22, 2020

Note this mirrors wsgi.py here:

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "pulpcore.app.settings")

And manage.py:

os.environ.setdefault("DJANGO_SETTINGS_MODULE", "pulpcore.app.settings")

This aligns the content service to the WSGI service (API) which already
sets a default env var for DJANGO_SETTINGS_MODULE. By providing a
default, the systemd service doesn't have to duplicate this and makes
configuration easier.

fixes #7179
@ekohl ekohl force-pushed the 7179-default-settings-in-content branch from a0056d4 to 6a2e7f3 Compare July 22, 2020 14:48
@ekohl
Copy link
Contributor Author

ekohl commented Jul 22, 2020

Updated from misc to bugfix.

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmbouter bmbouter merged commit 67f5c07 into pulp:master Jul 22, 2020
@ekohl ekohl deleted the 7179-default-settings-in-content branch July 22, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants