Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "HttpDownloader control on response codes 400+" #814

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Jul 30, 2020

Reverts #810

@pulpbot
Copy link
Member

pulpbot commented Jul 30, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@fao89 fao89 force-pushed the revert-810-7117 branch 2 times, most recently from 7973643 to d5f30c5 Compare July 31, 2020 18:02
fao89 added a commit to fao89/pulp_rpm that referenced this pull request Jul 31, 2020
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to revert the release note. I recommend using git revert to create the commit.

@fao89
Copy link
Member Author

fao89 commented Aug 3, 2020

We also need to revert the release note. I recommend using git revert to create the commit.

the subclass thing remains, so the changelog still making sense, I just fixed a typo

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, there is still the subclassing change; thanks for pointing that out. This look great!

@bmbouter bmbouter merged commit 70b0f70 into pulp:master Aug 3, 2020
fao89 added a commit to fao89/pulp_rpm that referenced this pull request Aug 3, 2020
fao89 added a commit to fao89/pulp_rpm that referenced this pull request Aug 4, 2020
fao89 added a commit to fao89/pulp_rpm that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants