-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "HttpDownloader
control on response codes 400+"
#814
Conversation
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
7973643
to
d5f30c5
Compare
Required PR: pulp/pulpcore#814 https://pulp.plan.io/issues/7095 closes #7095 [nocoverage]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to revert the release note. I recommend using git revert
to create the commit.
the subclass thing remains, so the changelog still making sense, I just fixed a typo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, there is still the subclassing change; thanks for pointing that out. This look great!
Required PR: pulp/pulpcore#814 https://pulp.plan.io/issues/7095 closes #7095 [nocoverage]
Required PR: pulp/pulpcore#814 https://pulp.plan.io/issues/7095 closes #7095 [nocoverage]
Required PR: pulp/pulpcore#814 https://pulp.plan.io/issues/7095 closes #7095 [nocoverage]
Reverts #810