Problem: OpenAPI schema for distribution delete is wrong #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: rename 'delete' method on the ViewSet to 'destroy' This patch also updates the schema for orphan delete. fixes: pulp#4638 https://pulp.plan.io/issues/4638
dkliban
changed the title
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=========================================
+ Coverage 65.56% 65.66% +0.1%
=========================================
Files 65 65
Lines 3014 3017 +3
=========================================
+ Hits 1976 1981 +5
+ Misses 1038 1036 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: rename 'delete' method on the ViewSet to 'destroy'
This patch also updates the schema for orphan delete.
fixes: #4638
https://pulp.plan.io/issues/4638