Exceptions during export-process will result in incomplete export bei… #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7246 |
daviddavis
reviewed
Sep 9, 2020
|
|
||
| In the event of any failure during an export, the process will clean up any partial | ||
| export-files that may have been generated. Export-files can be very large; this will | ||
| preserve available space in the export-directory. |
daviddavis
reviewed
Sep 9, 2020
| the_export.toc_info = {"file": output_file_info_path, "sha256": toc_hash} | ||
| finally: | ||
| # whatever may have happened, make sure we save the export | ||
| the_export.save() |
daviddavis
reviewed
Sep 9, 2020
daviddavis
approved these changes
Sep 9, 2020
…ng removed as cleanup. fixes #7246
ggainey
force-pushed
the
7246_cleanup_exp_fails
branch
from
7e7ad60
to
bb9a1ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng removed as cleanup.
fixes #7246
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html