Provide a way to get PK from resource URI without evaluating query #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
extract-uri
branch
3 times, most recently
from
7f6194e
to
6773851
Compare
|
Attached issue: https://pulp.plan.io/issues/7483 |
dralley
force-pushed
the
extract-uri
branch
from
6773851
to
009f1f3
Compare
dralley
added a commit
to dralley/pulp_rpm
that referenced
this pull request
Sep 22, 2020
Required PR: pulp/pulpcore#927 closes: #7483 https://pulp.plan.io/issues/7483
dralley
added a commit
to dralley/pulp_rpm
that referenced
this pull request
Sep 22, 2020
[nocoverage] Required PR: pulp/pulpcore#927 closes: #7483 https://pulp.plan.io/issues/7483
[noissue] related to #7483 https://pulp.plan.io/issues/7483
dralley
force-pushed
the
extract-uri
branch
from
009f1f3
to
3d85da4
Compare
|
The |
|
@daviddavis I was thinking about that earlier and decided that it couldn't be, the purpose is slightly orthogonal. The is code should only ever return a PK or a failure, the other code should fall back to doing a multi-attribute search. Re-using it would mean re-doing part of the work. |
daviddavis
approved these changes
Sep 22, 2020
dralley
added a commit
to dralley/pulp_rpm
that referenced
this pull request
Sep 22, 2020
[nocoverage] Required PR: pulp/pulpcore#927 closes: #7483 https://pulp.plan.io/issues/7483
dralley
added a commit
to dralley/pulp_rpm
that referenced
this pull request
Sep 22, 2020
[nocoverage] Required PR: pulp/pulpcore#927 closes: #7483 https://pulp.plan.io/issues/7483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #7483
https://pulp.plan.io/issues/7483