Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add master-detail Publications #94

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

daviddavis
Copy link
Contributor

daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request Apr 23, 2019
daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request Apr 24, 2019
@daviddavis daviddavis force-pushed the issue4678 branch 3 times, most recently from 30fb985 to 5066812 Compare April 24, 2019 14:05
daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request Apr 24, 2019
@daviddavis daviddavis force-pushed the issue4678 branch 2 times, most recently from 2f8c8dd to 16f63cd Compare April 24, 2019 15:02
@daviddavis daviddavis requested a review from a team April 24, 2019 15:02
@nixocio
Copy link

nixocio commented Apr 24, 2019

This change will break tests in all other plugins as well.

@nixocio
Copy link

nixocio commented Apr 24, 2019

I will check pulp_file, and pulp_rpm.

@nixocio
Copy link

nixocio commented Apr 24, 2019

I verified: pulp_docker, pulp_file and pulp_rpm. None of them use this PUBLICATIONS_PATH variable.

@nixocio
Copy link

nixocio commented Apr 24, 2019

Error during the installation process:

TASK [Check for podman] ********************************************************
fatal: [localhost]: FAILED! => changed=true 
  cmd:
  - which
  - podman
  delta: '0:00:00.002759'
  end: '2019-04-24 15:07:51.187667'
  msg: non-zero return code
  rc: 1
  start: '2019-04-24 15:07:51.184908'
  stderr: ''
  stderr_lines: []
  stdout: ''
  stdout_lines: <omitted>
...ignoring

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #94 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   67.97%   67.82%   -0.15%     
==========================================
  Files          65       65              
  Lines        3016     3018       +2     
==========================================
- Hits         2050     2047       -3     
- Misses        966      971       +5
Impacted Files Coverage Δ
pulpcore/app/serializers/publication.py 100% <100%> (ø) ⬆️
pulpcore/app/models/publication.py 70.66% <100%> (+0.39%) ⬆️
pulpcore/app/models/task.py 63.55% <0%> (-4.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e43d21...6eef8fc. Read the comment docs.

daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request Apr 24, 2019
daviddavis pushed a commit to daviddavis/pulp_ansible that referenced this pull request Apr 25, 2019
daviddavis pushed a commit to daviddavis/pulp_ansible that referenced this pull request Apr 25, 2019
@daviddavis daviddavis merged commit 20a7a54 into pulp:master Apr 25, 2019
daviddavis pushed a commit to daviddavis/pulp_ansible that referenced this pull request Apr 26, 2019
daviddavis pushed a commit to daviddavis/pulp_ansible that referenced this pull request Apr 29, 2019
daviddavis pushed a commit to daviddavis/pulp_file that referenced this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants