Removes use of pulpcore.app.settings from functional tests. #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7690 |
dkliban
force-pushed
the
7690
branch
2 times, most recently
from
c7e0c2f
to
d036244
Compare
mdellweg
reviewed
Oct 13, 2020
pulpcore/tests/functional/utils.py
Outdated
| if "bin/python" in line.split()[4]: | ||
| bin_dir = line.split()[4].rsplit("/", maxsplit=1)[0] | ||
| dynaconf = "{}/dynaconf".format(bin_dir) | ||
| stdout = cli_client.run((dynaconf, "list", "-k", setting_name)).stdout |
There was a problem hiding this comment.
Should we wrap this in a pulpcore-manager subcommand?
pulpcore-manager list-settings might be handy.
There was a problem hiding this comment.
i just noticed that there is a pulpcore-manager print_settings command.
There was a problem hiding this comment.
I just realized that command is only available on our dev boxes and not on production installs.
dkliban
force-pushed
the
7690
branch
3 times, most recently
from
84b5935
to
b41141a
Compare
mdellweg
reviewed
Oct 15, 2020
pulpcore/tests/functional/utils.py
Outdated
| @@ -60,3 +61,33 @@ def delete_orphans(): | |||
| """Delete orphans through bindings.""" | |||
| response = OrphansApi(core_client).delete() | |||
| monitor_task(response.task) | |||
|
|
|||
|
|
|||
| def get_pulp_setting(cli_client, setting_name, python_type="str"): | |||
There was a problem hiding this comment.
Just wondering, whether this code should live in pulp-smash.
Other plugins might need it, too.
There was a problem hiding this comment.
I agree. I'll move this code there and release a new version of pulp-smash.
mdellweg
approved these changes
Oct 22, 2020
goosemania
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7690
https://pulp.plan.io/issues/7690