Fixes #7716 - Incremental export not enabled even if start_version is… #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthaa
force-pushed
the
increment-with-start-versions
branch
2 times, most recently
from
67bbd14
to
26446e7
Compare
|
Attached issue: https://pulp.plan.io/issues/7716 |
ggainey
reviewed
Oct 20, 2020
CHANGES/7716.bugfix
Outdated
| @@ -0,0 +1 @@ | |||
| Incremental export not happening if last export was null even if start_version is provided | |||
There was a problem hiding this comment.
See https://docs.pulpproject.org/pulpcore/contributing/git.html#changelog-update for changelog style. 'Past simple tense' suggests changing this to something more like:
"Fixed incremental export to happen if start_version provided, even if last_export is null."
ggainey
reviewed
Oct 20, 2020
| @@ -142,8 +142,9 @@ def _incremental_requested(the_export): | |||
| full = the_export.params.get("full", True) | |||
| if isinstance(full, str): | |||
| full = bool(strtobool(full)) | |||
| starting_versions_provided = len(the_export.params.get("start_versions", [])) > 0 | |||
There was a problem hiding this comment.
Tested in my env and confirm it works as desired.
… even if last_export is null
parthaa
force-pushed
the
increment-with-start-versions
branch
from
26446e7
to
5ec2e63
Compare
goosemania
approved these changes
Oct 20, 2020
daviddavis
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7716 - Incremental export not enabled even if start_version is provided.