Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite publish logic #132

Merged
merged 17 commits into from
May 28, 2024
Merged

Rewrite publish logic #132

merged 17 commits into from
May 28, 2024

Commits on May 18, 2024

  1. Initial attempt to rewrite publish logic

    @confused-Techie
    confused-Techie committed May 18, 2024
    Configuration menu
    Copy the full SHA
    9cda15e View commit details
    Browse the repository at this point in the history

  2. Condense rename logic during actual publication

    @confused-Techie
    confused-Techie committed May 18, 2024
    Configuration menu
    Copy the full SHA
    5911d3f View commit details
    Browse the repository at this point in the history

  3. Remove duplicate tag declaration

    @confused-Techie
    confused-Techie committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1fd6a5b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Use existing code, ensure to await, log for assistance

    @confused-Techie
    confused-Techie committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ab1fcd5 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Remove extra logging, fix test to new value

    @confused-Techie
    confused-Techie committed May 27, 2024
    Configuration menu
    Copy the full SHA
    df51c83 View commit details
    Browse the repository at this point in the history

  2. Also check for tag existence before erroring out

    @confused-Techie
    confused-Techie committed May 27, 2024
    Configuration menu
    Copy the full SHA
    af47f04 View commit details
    Browse the repository at this point in the history

  3. Only create and assign tag if there isn't a user provided one

    @confused-Techie
    confused-Techie committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1d4852d View commit details
    Browse the repository at this point in the history

  4. Ensure to only exit early if also missing rename, fix logic error in … 

    …rename
    @confused-Techie
    confused-Techie committed May 27, 2024
    Configuration menu
    Copy the full SHA
    dee2d17 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @confused-Techie
    confused-Techie committed May 27, 2024
    Configuration menu
    Copy the full SHA
    b06f1a7 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Add some verbose logging

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    cf9f1ae View commit details
    Browse the repository at this point in the history

  2. Make verbose option a boolean

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d3153e1 View commit details
    Browse the repository at this point in the history

  3. Make sane length checks, ensure tag always has a length

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a16919e View commit details
    Browse the repository at this point in the history

  4. Also protect version from being undefined

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d8ef281 View commit details
    Browse the repository at this point in the history

  5. Finally normalize rename to a string

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9baec4c View commit details
    Browse the repository at this point in the history

  6. Clean up length logic now that we have normalized values

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    01af708 View commit details
    Browse the repository at this point in the history

  7. Remove outdated verbose flag

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    567b247 View commit details
    Browse the repository at this point in the history

  8. Confidently check length now that we normalize variable values

    @confused-Techie
    confused-Techie committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1b9ebd2 View commit details
    Browse the repository at this point in the history