Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty featured packages #38

Merged
merged 1 commit into from Nov 15, 2022
Merged

Fix empty featured packages #38

merged 1 commit into from Nov 15, 2022

Conversation

jonian
Copy link
Contributor

@jonian jonian commented Nov 13, 2022

This fixes #37 and pulsar-edit/pulsar#137 by not checking for latest key in releases. If the issue pulsar-edit/package-backend#3 is fixed, then this PR can be rejected.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and approve this change as well. While I do plan on resolving pulsar-edit/package-backend#3, this will resolve the issue in the meantime, as well as it'll start pulling the releases again after the fact since you used an optional chaining here.

Thanks for the contribution!

@confused-Techie confused-Techie merged commit 5249f96 into pulsar-edit:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not showing featured packages
3 participants