Skip to content

Commit

Permalink
Upgrade jasmine to be on 2.x, make the first spec file pass
Browse files Browse the repository at this point in the history
* Stop using vendored jasmine (it needs to be deleted later)
* Add jasmine 2.5.3 as direct dependency
* Drop using asyncifyJasmineFn helper, jasmine has a `done` callback now
* Log deprecation warnings for the ConsoleReporter
* Replace broken calls on spies
  * andCallFake -> and.callFake
  * andReturn -> and.returnValue
  * reset -> calls.reset
  * unspy -> and.callThrough
* Update addMatchers syntax
  • Loading branch information
kiskoza committed Apr 24, 2024
1 parent d3cd65d commit dc2f4c8
Show file tree
Hide file tree
Showing 6 changed files with 337 additions and 237 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
"image-view": "file:packages/image-view",
"incompatible-packages": "file:packages/incompatible-packages",
"jasmine-node": "git+https://github.com/kevinsawicki/jasmine-node.git#81af4f953a2b7dfb5bde8331c05362a4b464c5ef",
"jasmine": "2.5.3",
"key-path-helpers": "^0.4.0",
"keybinding-resolver": "file:./packages/keybinding-resolver",
"language-c": "file:packages/language-c",
Expand Down

0 comments on commit dc2f4c8

Please sign in to comment.