Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree-sitter rolling fixes, 1.118 edition #1010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Tree-sitter rolling fixes, 1.118 edition #1010

wants to merge 3 commits into from

Conversation

savetheclocktower
Copy link
Sponsor Contributor

More fixes for TypeScript/JavaScript, plus fixes in grammar-matching logic for PHP. More to come, no doubt.

@savetheclocktower
[language-(java|type)script] Prevent the FOO in <FOO.Bar>…
55e869c 
…from getting a `constant.other` scope applied.

Also ensure correct scoping of JSX tags even when the tag name is a member expression like `Foo.Bar`.
@savetheclocktower
[language-php] Add a firstLineRegex…
8bf199a 
…so that the grammar-choosing logic picks the modern Tree-sitter grammar more consistently.
@savetheclocktower
[language-php] Update tree-sitter-php to latest…
c04a38b 
…to gain support for type annotations on class constants, among other things.
@savetheclocktower savetheclocktower mentioned this pull request May 18, 2024
Open
@Psychosynthesis
Copy link

I wonder how to find out what has changed in the binary files? Or are they automatically generated from the rest?

I'm just starting to slowly understand the entire codebase, so I don't understand a lot.

@savetheclocktower
Copy link
Sponsor Contributor Author

I wonder how to find out what has changed in the binary files? Or are they automatically generated from the rest?

I'm just starting to slowly understand the entire codebase, so I don't understand a lot.

The WASM files are generated from their various Tree-sitter repos. This is partly why we introduced the parserSource convention in the grammar files — it tells you which commit SHA the WASM was built from.

Hence if you wanted to know what's changed in tree-sitter-php, you could compare b569a5f2c0d592e67430520d1a0e1f765d83ceb0 to 27afeb02e49ff30acd17b67897b1c0114561a38c. Not the easiest thing to do, but it's at least possible.

@Psychosynthesis
Copy link

@savetheclocktower thanx, got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@savetheclocktower @Psychosynthesis