Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE.md #171

Merged
merged 3 commits into from Nov 22, 2022
Merged

Update LICENSE.md #171

merged 3 commits into from Nov 22, 2022

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented Nov 21, 2022

Update the MIT Licence with Pulsar

Added "MIT License" to the top as provided by the template at https://choosealicense.com/licenses/mit/ and also the standard template from GH.

Adds a Copyright line for "2022 Pulsar-Edit" - feel free to suggest if this should be different, e.g. "Pulsar", "pulsar-edit" (repo name) or "Pulsar Team/Community" or something.

Moves the GH line down but adds "original work" wording to the start.

The actual licence wording is identical but just reformatted in regards to newlines by what is provided by https://choosealicense.com/licenses/mit/ and the GH MIT licence template. This was checked by removing all whitespace and comparing the two strings which came out to no differences.

Copy link
Contributor

@sertonix sertonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this pull request because it does what it should.
But this pull request could also update the LICENSE.md of the packages in this repository.

@Daeraxa
Copy link
Member Author

Daeraxa commented Nov 21, 2022

Good point, I hadn't even thought of those, I can go and do those as well.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

The Pulsar-Edit really makes sense as that is our Org name, and kinda encompasses all of us.
As for adding in the other packages, I'd honestly rather see those removed. As we are using the same license everywhere, and that code is now in this repo. Unless we need to do any fancy duel licensing on any bundled packages, I'd vote to just remove them.

But regardless, that feels a bit out of scope here, so I'll approve, and leave for a bit before merging to ensure others are able to review as well.

@Daeraxa
Copy link
Member Author

Daeraxa commented Nov 22, 2022

I've been through the others, there are more than a few which are more than just the MIT licence, for example the typescript one has a MS copyright and all the converted textmate grammars have their original repo licences appended too which we should be keeping.

I'll do these in a separate PR

@confused-Techie
Copy link
Member

I've been through the others, there are more than a few which are more than just the MIT licence, for example the typescript one has a MS copyright and all the converted textmate grammars have their original repo licences appended too which we should be keeping.

I'll do these in a separate PR

That sounds awesome to me. Remove that which is a normal MIT license. But for the others that sounds like a great plan. I'll merge this one and let you start on that then

@confused-Techie confused-Techie merged commit acdbc1a into pulsar-edit:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants