Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding to Pulsar - Icons and Logos #173

Merged
merged 12 commits into from Nov 28, 2022
Merged

Rebranding to Pulsar - Icons and Logos #173

merged 12 commits into from Nov 28, 2022

Conversation

mauricioszabo
Copy link
Contributor

image

@Daeraxa
Copy link
Member

Daeraxa commented Nov 22, 2022

Question about the logo location (packages/about/lib/components/atom-logo.js) is there nowhere more central we can use so that it can be referenced by other packages or the app without having to duplicate the resource?
There was a (short) conversation on Discord about it.

@Spiker985
Copy link
Member

We should also (if we have it) add a banner to the README.md

@confused-Techie
Copy link
Member

This overall looks great to me, although do we want to have any consideration to generating png's at the different sizes that have been removed? Would those be useful, or were we essentially not using them.

Or maybe it's better for us to wait on having all the right sizes until we have a final icon, and we just merge this one, so that we have something for now?

Because if it's the latter I say lets get it merged

@Spiker985
Copy link
Member

I thought that I saw the largest file being 2048x2048 which is the largest file we had before if I'm not mistaken.

I wrote something to generate scaled images before, so we should just be able to generate the scaled down images, and recreate the icns files, the individual pngs and the icos

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Spiker985 you're right, I missed the large icon.

In that case this looks great to me, and I'll happily merge it as long as it's complete

Copy link
Member

@Spiker985 Spiker985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine for an initial - this will evolve with our app styling choices anyway

@confused-Techie
Copy link
Member

With two approvals I'll go ahead and merge this one, if needed a PR can always be made later to adjust these.

@confused-Techie confused-Techie merged commit f1c425b into master Nov 28, 2022
@Spiker985 Spiker985 deleted the new-icons branch February 24, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants