New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebranding to Pulsar - Icons and Logos #173
Conversation
mauricioszabo
commented
Nov 22, 2022
Question about the logo location (packages/about/lib/components/atom-logo.js) is there nowhere more central we can use so that it can be referenced by other packages or the app without having to duplicate the resource? |
We should also (if we have it) add a banner to the README.md |
This overall looks great to me, although do we want to have any consideration to generating png's at the different sizes that have been removed? Would those be useful, or were we essentially not using them. Or maybe it's better for us to wait on having all the right sizes until we have a final icon, and we just merge this one, so that we have something for now? Because if it's the latter I say lets get it merged |
I thought that I saw the largest file being 2048x2048 which is the largest file we had before if I'm not mistaken. I wrote something to generate scaled images before, so we should just be able to generate the scaled down images, and recreate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spiker985 you're right, I missed the large icon.
In that case this looks great to me, and I'll happily merge it as long as it's complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fine for an initial - this will evolve with our app styling choices anyway
With two approvals I'll go ahead and merge this one, if needed a PR can always be made later to adjust these. |