Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some about package tests (6 Resolved Tests) #310

Merged
merged 2 commits into from Jan 7, 2023
Merged

Resolve some about package tests (6 Resolved Tests) #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e761cf3
Resolve `getReleaseNotesURLForVersion` Tests
confused-Techie Jan 6, 2023
55c6730
Resolve Update Link (Added TODO while here)
confused-Techie Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/about/lib/components/about-view.js
View file
Open in desktop
Expand Up @@ -46,6 +46,7 @@ module.exports = class AboutView extends EtchComponent {
handleTermsOfUseClick(e) {
e.preventDefault();
shell.openExternal('https://atom.io/terms'); //If we use this then this URL will need updating but button disabled (L#182)
// TODO Update to Privacy Policy once `pulsar-edit.github.io` #161 is resolved
}

handleHowToUpdateClick(e) {
Expand Down Expand Up @@ -223,4 +224,3 @@ module.exports = class AboutView extends EtchComponent {
return 'info';
}
};

21 changes: 11 additions & 10 deletions packages/about/spec/update-manager-spec.js
View file
Open in desktop
Expand Up @@ -8,26 +8,27 @@ describe('UpdateManager', () => {
});

describe('::getReleaseNotesURLForVersion', () => {
it('returns atom.io releases when dev version', () => {
it('returns pulsar-edit download page when dev version', () => {
expect(
updateManager.getReleaseNotesURLForVersion('1.7.0-dev-e44b57d')
).toContain('atom.io/releases');
).toContain('pulsar-edit.dev/download');
});

it('returns the page for the release when not a dev version', () => {
expect(updateManager.getReleaseNotesURLForVersion('1.7.0')).toContain(
'atom-ide-community/atom/releases/tag/v1.7.0'
expect(updateManager.getReleaseNotesURLForVersion('1.100.0')).toContain(
'pulsar-edit/pulsar/releases/tag/v1.100.0'
);
expect(updateManager.getReleaseNotesURLForVersion('v1.7.0')).toContain(
'atom-ide-community/atom/releases/tag/v1.7.0'
expect(updateManager.getReleaseNotesURLForVersion('v1.100.0')).toContain(
'pulsar-edit/pulsar/releases/tag/v1.100.0'
);
// TODO: Since we no longer follow release channels, is it useful to continue testing their state?
expect(
updateManager.getReleaseNotesURLForVersion('1.7.0-beta10')
).toContain('atom-ide-community/atom/releases/tag/v1.7.0-beta10');
updateManager.getReleaseNotesURLForVersion('1.100.0-beta10')
).toContain('pulsar-edit/pulsar/releases/tag/v1.100.0-beta10');
expect(
updateManager.getReleaseNotesURLForVersion('1.7.0-nightly10')
updateManager.getReleaseNotesURLForVersion('1.100.0-nightly10')
).toContain(
'atom-ide-community/atom-nightly-releases/releases/tag/v1.7.0-nightly10'
'pulsar-edit/pulsar-nightly-releases/releases/tag/v1.100.0-nightly10'
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/about/spec/update-view-spec.js
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@ describe('UpdateView', () => {

let args = shell.openExternal.mostRecentCall.args;
expect(shell.openExternal).toHaveBeenCalled();
expect(args[0]).toContain('installing-atom');
expect(args[0]).toContain('installing-pulsar');
});
});

Expand Down