Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable middle-click paste for cursor position test. #36

Conversation

fabianfiorotto
Copy link
Contributor

When you run the test on Linux you get this error message

mouse input
  on the lines
    when there is only one cursor
      it positions the cursor on single-click or when middle-clicking
        Expected { row : 0, column : 25 } to equal [ 0, 0 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4076:54)
        Expected { row : 0, column : 54 } to equal [ 0, 79 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4109:54)
        Expected { row : 1, column : 25 } to equal [ 1, 0 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4123:54)
        Expected { row : 3, column : 39 } to equal [ 3, 14 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4134:54)
        Expected { row : 3, column : 40 } to equal [ 3, 15 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4146:54)
        Expected { row : 3, column : 39 } to equal [ 3, 14 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4160:54)
        Expected { row : 3, column : 41 } to equal [ 3, 16 ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4172:54)
        Expected [ { screenRange : { start : { row : 0, column : 0 }, end : { row : 0, column : 1 } }, options : { clip : false } }, { screenRange : { start : { row : 0, column : 25 }, end : { row : 0, column : 26 } }, options : { clip : false } }, { screenRange : { start : { row : 12, column : 2 }, end : { row : 12, column : 3 } }, options : { clip : false } }, { screenRange : { start : { row : 12, column : 27 }, end : { row : 12, column : 28 } }, options : { clip : false } }, { screenRange : { start : { row : 0, column : 29 }, end : { row : 0, column : 30 } }, options : { clip : false } }, { screenRange : { start : { row : 0, column : 54 }, end : { row : 0, column : 55 } }, options : { clip : false } }, { screenRange : { start : { row : 1, column : 0 }, end : { row : 1, column : 1 } }, options : { clip : false } }, { screenRange : { start : { row : 1, column : 25 }, end : { row : 1, column : 26 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 14 }, end : { row : 3, column : 15 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 39 }, end : { row : 3, column : 40 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 15 }, end : { row : 3, column : 16 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 40 }, end : { row : 3, column : 41 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 14 }, end : { row : 3, column : 15 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 39 }, end : { row : 3, column : 40 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 16 }, end : { row : 3, column : 17 } }, options : { clip : false } }, { screenRange : { start : { row : 3, column : 41 }, end : { row : 3, column : 42 } }, options : { clip : false } } ] to equal [  ].
          at jasmine.Spec.<anonymous> (pulsar/spec/text-editor-component-spec.js:4174:51)

Middle-click is for pasting text on Linux. You have to disable this feature in order to pass these tests. There is already a line for that but it setting the wrong value.

@confused-Techie
Copy link
Member

So this is a rather simple PR, that seems to successfully solve the tests it wants to. It has been up for quite some time without much activity so I'll go ahead and merge to main, thanks for the contribution!

As looking at its state of being in line with our test failure expectancy, while it did fail to install on all tests from Windows to Mac, since what this changes is so little I don't assume that is an issue of the changes made to this PR, and is more likely issues related to the state of the build process.

So in that case looking at its Ubuntu tests it does fantastic with only 14 Editor Failures, and 22 Package Failures. While we expect 55 Editor Failures, and 22 Package Failures.

@confused-Techie confused-Techie merged commit 02e9286 into pulsar-edit:disable-failing-tests Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants