Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Small Readme Touchup #404

Merged
merged 1 commit into from Feb 26, 2023
Merged

[skip-ci] Small Readme Touchup #404

merged 1 commit into from Feb 26, 2023

Conversation

confused-Techie
Copy link
Member

This PR addresses a few issues I've seen around the internet about our readme.

  1. We don't mention in the readme that we are a fork. We thought it was enough to put on the website, and we assumed people would only know of us because of the fact we are a fork of Atom. But seems there's enough natural discoverability happening that we need to explicitly mention we are a fork rather than a new editor. So this touch up does that.
  2. Additionally, the readme uses terms like we and our which was written by the Atom team, and we have been using it, which personally feels a little dishonest to me. As we didn't design the editor. It was already done. So this keeps the same gist of what was being said, but removes uses of we or our.

Like mentioned on Discord, we will absolutely want to do more to make this better, but for something I'm hoping can be reviewed quickly this is the simplest thing I could think of to make the needed changes.

@Daeraxa
Copy link
Member

Daeraxa commented Feb 26, 2023

I think this is a perfectly acceptable approach to appease some of those comments. Obviously if we do a large scale rebranding we can make this more obvious but I think in the short term at the very least it covers the biggest complaints.

@confused-Techie
Copy link
Member Author

Thanks for the review @Daeraxa, I think the changes here are small enough that we could probably merge if it's approved. But appreciate it

@confused-Techie
Copy link
Member Author

Thanks for the approve, I'll go ahead and merge this one.

Again the fast merge time is just because of active discourse around concerns that we don't list that we are a fork, and I'm wanting to fix that as quickly as we can. I seriously invite anyone to take a much more thorough approach in fixing our readme as a lot more can be done. But for now this seems enough to answer the concerns posted.

@confused-Techie confused-Techie merged commit 7d933c5 into master Feb 26, 2023
@confused-Techie confused-Techie deleted the readme-touch-up branch February 26, 2023 21:33
@DeeDeeG
Copy link
Member

DeeDeeG commented Mar 1, 2023

I had been meaning to do something about both of these main items (mention we are a fork somewhere prominent, stop using "we" to refer to stuff the Atom team was describing as their accomplishments/vision/efforts, etc.).

This is along the lines of what I was thinking of doing, I just get shy about small and sentiment-based changes, a little nervous to touch anything, so I kept putting it off. Good to see it got done though!

Thanks for this!

@confused-Techie
Copy link
Member Author

Yeah of course, was largely inspired by a thread that appeared online, where us lacking these things was leading to a bad view of the project. So wanted to finally get in and make things more clear. So I absolutely wouldn't hesitate to at least point out when found in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants