Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly remove request #474

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Mostly remove request #474

merged 4 commits into from
Jun 13, 2023

Conversation

confused-Techie
Copy link
Member

As reported in #468 we still have request in quite a few repos, where it shouldn't be.

This PR removes, most of our direct usage of request. request is still used directly in PPM, and in settings-view here.

But since my PR to bundle PPM into the core, already removes request from settings-view I thought we could leave that for the time being.

Otherwise request is removed from direct usage in both autocomplete-css and language-less. Where it was only used for update scripts, so this should have no effect on users.

I did ensure both of these applications had the same results of running their update scripts from both usage of request and superagent. So their implementation is exactly the same.

With the only real changes needed in either, was within language-less that had some API differences (Mostly it seems that within CoffeeScript it fails to auto parse the content type, so that had to be added in manually, as well as the usage of the Promise callback.

@mauricioszabo
Copy link
Contributor

Mac builds are consistently failing, maybe we either need to merge-back master on this, or see why it isn't actually building...

@confused-Techie
Copy link
Member Author

@mauricioszabo I've just rebased this PR on master lets see if the numerous CI changes can improve our mac builds, or otherwise we know that mac failing to build is the result of this PR and we can investigate further.

@confused-Techie confused-Techie merged commit 952015f into master Jun 13, 2023
100 checks passed
@confused-Techie confused-Techie deleted the no-request branch June 13, 2023 04:39
@confused-Techie confused-Techie mentioned this pull request Jun 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants