Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #468 we still have
request
in quite a few repos, where it shouldn't be.This PR removes, most of our direct usage of
request
.request
is still used directly in PPM, and insettings-view
here.But since my PR to bundle PPM into the core, already removes
request
fromsettings-view
I thought we could leave that for the time being.Otherwise
request
is removed from direct usage in bothautocomplete-css
andlanguage-less
. Where it was only used for update scripts, so this should have no effect on users.I did ensure both of these applications had the same results of running their update scripts from both usage of
request
andsuperagent
. So their implementation is exactly the same.With the only real changes needed in either, was within
language-less
that had some API differences (Mostly it seems that within CoffeeScript it fails to auto parse the content type, so that had to be added in manually, as well as the usage of the Promise callback.