Rebrand + electron to 12 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge decaffinated master into rebrand
… bump-electron-12
… bump-electron-12
|
@mauricioszabo if this is the one you mean, I'd suggest merging it into master. Just so things can start clearing themselves out. I think we're good to merge it if it works. Though I'd almost suggest as mentioned in the pulsar-edit.github.io issues( and I think we mentioned it before?) but should probably convert and require pnpm. Not sure if that'd mess things up or help at this point. |
|
So, both PRs were already approved and we're not breaking any new tests on this branch. As discussed on Discord, I'm merging it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this, it's just for us to have a rebranded Electron 12 version of Pulsar and test things
Binaries here: https://cirrus-ci.com/github/pulsar-edit/pulsar/rebrand-and-bump-electron-to-12