Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower-case-ing the heredoc language #554

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Lower-case-ing the heredoc language #554

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f34e6bb
Lower-case-ing the heredoc language
mauricioszabo May 23, 2023
9a2dfcf
Highlighting heredocs as strings
mauricioszabo May 23, 2023
8058b62
Merge remote-tracking branch 'origin/master' into simple-ruby-fix
mauricioszabo Jun 20, 2023
f9f4638
No reason for these to be "final" when there's constant support
mauricioszabo Jun 21, 2023
a7c0bec
Fix typo on grammar name
mauricioszabo Jun 21, 2023
ab40f77
Another typo
mauricioszabo Jun 21, 2023
3426327
Fixing the insanity that is Ruby strings
mauricioszabo Jun 21, 2023
dae1575
Applying highlight just to the right place
mauricioszabo Jun 21, 2023
0db3806
Tests for HEREDOCs
mauricioszabo Jun 21, 2023
f0c4793
Activating the tree-sitter test
mauricioszabo Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

## [Unreleased]

- Fixed default tokenization of heredocs in Ruby (should be tokenized as string)
- Added a modern implementation of Tree-sitter grammars behind an experimental flag. Enable the “Use Modern Tree-Sitter Implementation” in the Core settings to try it out.

## 1.105.0
Expand Down
1 change: 1 addition & 0 deletions packages/language-ruby/grammars/ts/highlights.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@
(bare_string)
(heredoc_body)
(heredoc_beginning)
(heredoc_content)
] @string.unquoted.ruby

((heredoc_body) @meta.embedded
Expand Down
2 changes: 1 addition & 1 deletion packages/language-ruby/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports.activate = function() {
atom.grammars.addInjectionPoint('source.ruby', {
type: 'heredoc_body',
language(node) {
return node.lastChild.text;
return node.lastChild.text?.toLowerCase();
},
content(node) {
return node.descendantsOfType('heredoc_content')
Expand Down
Loading