Hardcode NSIS GUID #566
Merged
Hardcode NSIS GUID #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meadowsys
approved these changes
May 29, 2023
mauricioszabo
approved these changes
May 29, 2023
icecream17
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As inspired by #565 this PR hardcodes our GUID.
While the Electron-Builder docs recommend against this, this is the GUID we have already been using on Windows as generated from
dev.pulsar-edit.pulsar, so this isn't actually changing our GUID at all. This just ensures that even if we ever change theAppIDin the future the GUID will remain the same.Once this PR is merged, we can then create a PR to GitHub Desktop to allow integration, being confident knowing we won't accidentally break that integration.
But even if we ever do, I've added a comment explaining the purpose of hardcoding this value, and what needs to be done if it ever changes, to ensure anyone working on this can be on the same page.