Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yarn sane #567

Merged
merged 1 commit into from
May 30, 2023
Merged

Make yarn sane #567

merged 1 commit into from
May 30, 2023

Conversation

mauricioszabo
Copy link
Contributor

Basically, remove telemetry (I still don't believe everything phones home these days!) and ignore engines because some packages try to be smart and say heeey, I only work on newer nodes, even though there's nothing that prevents this to run on Node 14 like marked for example

@Daeraxa
Copy link
Member

Daeraxa commented May 30, 2023

No opposition at all but I can't seem to find either of these in the yarn v1 docs (we are using v1 right? Hence the .yarnrc?). Do these actually do stuff in v1?

@mauricioszabo
Copy link
Contributor Author

@Daeraxa honestly? Me neither. The documentation mentions yarnsomething.yaml but I could not make it work, so what I did was - I made the config changes with yarn config, found that they changed the global .yarnrc, moved this .yarnrc to pulsar's repo, tested again, and it worked, so.... 🤷‍♂️

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, while it's always lame to use undocumented, nonstandard features, I was able to locate the usage of enableTelemetry within the source code but couldn't seem to find any reference for a declaration of ignore-engines but if you've tested and it works, I'll accept I just can't find it. But absolutely a fan of this, telemetry for obvious reasons, but also all the engines warnings in logs is just unnecessary visual clutter I'll be more than happy to get rid of.

@mauricioszabo mauricioszabo merged commit 590c6d2 into master May 30, 2023
100 checks passed
@mauricioszabo mauricioszabo deleted the yarn-config branch May 30, 2023 15:26
@Daeraxa
Copy link
Member

Daeraxa commented May 30, 2023

@Daeraxa honestly? Me neither. The documentation mentions yarnsomething.yaml but I could not make it work, so what I did was - I made the config changes with yarn config, found that they changed the global .yarnrc, moved this .yarnrc to pulsar's repo, tested again, and it worked, so.... man_shrugging

.yarnrc.yaml is the new structure for yarn v2 config but we are using yarn v1 (I think??). I had a very quick go at seeing how easy it was to migrate to v2 a while ago but got lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants