Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Image doesn't appear at first open #579

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

asiloisad
Copy link
Contributor

@asiloisad asiloisad commented Jun 4, 2023

Fix the problem of image doesn't appear at first open #578 .

@asiloisad asiloisad changed the title fix #578 Fix: Image doesn't appear at first open Jun 4, 2023
@confused-Techie
Copy link
Member

Hey thanks a ton for contributing on this one!
I've personally seen this issue before in the Atom days, and had totally forgotten about it.

It's awesome to see al tests passing, and I'll go ahead and test this one out. Appreciate the PR!

@asiloisad
Copy link
Contributor Author

It my first time to make an pull request and I was make small mistake. I should create probably need to create a new branche before make a pul lrequest, because the fix one-light sticky headerandfix one-dark sticky header should be another one pull request. All commits are ok and work as desired, I can try to split it into two pull request if needed.

@confused-Techie
Copy link
Member

confused-Techie commented Jun 9, 2023

@asiloisad I honestly wouldn't worry to much about separate PRs here, everything is one the same topic addressing the same issue, so it should really be fine

--

EDIT: Reading this again, it's occurring to me that you're saying the sticky header's aren't actually relevant to this PR. Which if that is the case, yeah it's probably a good idea to revert those commits on this PR.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just tested this out, and it works perfectly! I've noticed this issue since the Atom days, so happy to see it was such a simple fix that just had to be discovered. But yeah this looks great, and I think it's good to merge!

The only thing @asiloisad is if you'd like you could add an entry to the change log, but if not we will handle it later

@confused-Techie confused-Techie merged commit 832eae2 into pulsar-edit:master Jun 13, 2023
194 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants