Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree-view sticky headers of one-dark & one-light themes #599

Merged
merged 2 commits into from Jul 6, 2023

Conversation

asiloisad
Copy link
Contributor

@asiloisad asiloisad commented Jun 18, 2023

The fixes of sticky headers are outdated and it generate some bugs now, like:

I have just deleted old fixes and everything looks working perfectly...

@confused-Techie
Copy link
Member

Thanks a ton for the PR! I'll have to test the binaries out once they are built and see what this does, but appreciate the contribution

@confused-Techie
Copy link
Member

@asiloisad So I hate to say, I've tried taking a look at this one a couple of times, and while I'm not seeing any negative effects of the change, I also can't replicate the issue it aims to be fixing either.

I've gotten with another maintainer who also can't replicate it. I'd love to be able to get your fix in, but would you mind detailing any steps on how to replicate the issue or maybe even a before after of this change fixing it for you? Since even if an edge case, obviously we want things to function as well as possible for everyone

@asiloisad
Copy link
Contributor Author

asiloisad commented Jul 5, 2023

image
At picture there is short tutorial how to reproduce the bug. I have test it with brand-new .pulsar.

@Daeraxa
Copy link
Member

Daeraxa commented Jul 5, 2023

I was able to replicate it with the above instructions. It looks like it indeed relates to this padding:

image

@asiloisad
Copy link
Contributor Author

asiloisad commented Jul 5, 2023

A strange padding has been introduced by fixes deleted in this commits. They were written to fix auto-revealed, but after deleting them I am not able to get any error related to it.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the additional steps to replicate, and @Daeraxa helpfully testing, can confirm this fixes the issue at hand, and doesn't seem to reintroduce the issue it originally aimed to fix.

Thanks a ton for the contribution @asiloisad and let's get this one merged!

@confused-Techie confused-Techie merged commit 0389eee into pulsar-edit:master Jul 6, 2023
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants