Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Better errors when something fails on search #2

Merged
merged 1 commit into from Sep 29, 2022
Merged

Conversation

mauricioszabo
Copy link

Before:
image

After:
image

@confused-Techie
Copy link
Member

@mauricioszabo just wanted to let you know that the backend codebase should already have a fix applied for returning { message: "Not Found" } instead of the proper []. The fix needs to just go live

I'm not sure if we want to still merge this because it very well could be helpful, especially to identify if theres any other bugs in the returns. Just wanted to let you know

@mauricioszabo
Copy link
Author

I think it's a good idea to merge, because if the server 500 or times out or, for some reason, our DNS gets outdated, or blocked, we can see what the server is running

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After dicussing this with @mauricioszabo looks like this will still be a good feature to have even with the backend returning properly for the item that initially brought about this change.

@mauricioszabo mauricioszabo merged commit 879e37a into master Sep 29, 2022
@mauricioszabo mauricioszabo deleted the better-errors branch September 29, 2022 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants