Upgrade to PEGjs 0.10… #15
Conversation
…removing our dependency on `loophole`. Also reintroduced the generated PEGjs file to improve startup time. In theory we can move `pegjs` to `devDependencies`, but for now we can just try to load the compiled version and fall back to generating it manually from the `.pegjs` file if it isn't present.
There was a problem hiding this comment.
Overall this looks rad! Totally happy to see things get more up to date, and personally much prefer keeping our generated PegJS here, and move PegJS to our devDependencies, where if we get all of our package's to do this, we might be able to stop unpacking (or even installing) PegJS in our binaries, which can help save us some size on install.
Real fast though, what's the purpose of adding eslint as a devDependency? Was that already being used here and I've just missed it?
It probably wasn’t, but likely only because this used to all be CoffeeScript. The coding styles vary between repos. Older code tends to enforce absence of semicolons, whereas new JS that hasn't been decaffeinated tends to mandate semicolons. At some point we'll want to harmonize all this, so bringing |
|
Yeah I'm not against it at all. Just wondering if it was used much anywhere yet. But that sounds good to me. And totally agree we will need to find out what we prefer, likely setting up some sort of official styleguide, that we could all get behind and enforce via automated tools |
…removing our dependency on
loophole. (This was the weirdevalthing. Newer versions of PEGjs no longer require usage ofeval.Also reintroduced the generated PEGjs file to improve startup time, giving us a second way to avoid
eval. In theory we can movepegjstodevDependencies, but for now we can just try to load the compiled version and fall back to generating it manually from the.pegjsfile if it isn't present.