deps: Update superstring to Pulsar's fork #5
Conversation
Should allow building on at least NodeJS 18.x
|
I would have accidentally opened this pull request against GitHub's UI about PRs pointing to forks could be a little less presumptuous about pointing PRs against the parent repo... grumble grumble grumble. ANYHOW, back on topic: I kind of want to add |
Maybe this will fix issues with a missing submodule (?) on Windows?
|
If it's of any help, thought I'd point out where I've seen this error message before. |
|
So, yeah, the Broken in npm 7.x, not restored. Docs still claim this is supported, but it is not actually working: https://docs.npmjs.com/cli/v10/commands/npm-install
(Not true as of npm 7.) (Not to put too fine a point on it, but as far as I can tell, this change was unplanned, unannounced and undocumented. Sheer oversight, and effectively willy-nilly breaking changes. In pursuit of cleaning up the codebase, refactoring, and faster performance. (And apparently done (by accident) during the pursuit of a better dependency resolution algorithm, which is at least a nice goal to be pursuing, admittedly.) All this in the premier dependency management and build tool in the NodeJS ecosystem. Go figure. If anyone wonders what upset me so much that I have never gotten over npm 7, here you go, one more reason.) EDIT to add: I think they were coming from the right place, but they were way, way, way too bold about the changes, and way, way, way too confident about the lack of disruptive breaking changes they supposedly didn't have in npm 7... And they didn't have adequate [ability to] outreach to npm users to spot breaking changes before they became de-facto maintainer-blessed changes as of npm 7, since they didn't want to churn and introduce what could be construed as further breaking changes by fixing them after the semver-major stable npm 7.0 had already been released... I consider the whole thing botched as regards unintended breaking changes, but since I'm the one who's complaining the loudest, it seems to have worked out fine for most users. It just shook out especially extremely badly for an Atom contributor who was dealing with a lot of legacy tech... |
This reverts commit c571758.
Should fix the "missing win-iconv submodule" situation, which breaks the Windows builds.
|
We may want to just commit the I am thinking it's PR time to just commit the files instead of dealing with submodule headaches. UPDATE: Here it is (pulsar-edit/superstring#6). A PR to vendor |
Workaround for a weird Yarn v1.x issue, which only happens when global npm is v9.7.2 or newer. See pulsar-edit/ppm#101 for an explanation.
This revision makes superstring easily buildable on Windows as a git dependency or tarball URL dependency, by vendoring in the 'win-iconv' files as regular files, not as a submodule. npm and Yarn do not necessarily install submodules of git repos as of their latest versions. And tarballs wouldn't be generated with the submodule content, as far as I know. So, doing it this way is much more broadly compatible with how the package managers tend to work these days.
Should fix getDiff tests on Windows?
This reverts commit 45a4586.
This reverts commit 62d6ebf.
This reverts commit c38e44f.
|
This is finally ready! After the (I often like to clean up my WIP branches, this has a bunch of reverts in it, but I dunno if I prefer to clean them up and rebase, or leave the evidence of all the things I had to try to get here. Anyhow, just opening it back up for now! Reviews welcome!) |
There was a problem hiding this comment.
Lets get this merged! Super excited to see we were finally able to get this one going!
Thanks a ton for following through!
Now with all these changes, it's just time to get them all upstream, and be happy with our smaller binaries, and more up to date everything lol
Identify the Bug
The
superstringdependency of this package can't build on NodeJS 18 or newer. (Also affects thegithubpackage that depends on this one.)Description of the Change
Update
superstringto the tip of pulsar-edit org's fork of superstring's default branch (https://github.com/pulsar-edit/superstring)Alternate Designs
N/A (none were considered)
Possible Drawbacks
None anticipated, the workaround for building on Node 18 was done in a backward-compatible manner by detecting older NodeJS and using the original prior code on those NodeJS versions.
Verification Process
CI should pass, this package should remain functional with this bump.
Release Notes
deps: Update superstring to pulsar's fork