Merge branch 'master' of https://github.com/zikolach/vue-tour into fe…

…ature/zikolach-master # Conflicts: # package-lock.json # src/components/VStep.vue
pulsardev · Sep 2, 2018 · f5f3e00 · f5f3e00
2 parents d18fca6 + d559e71
commit f5f3e00
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/components/VStep.vue b/src/components/VStep.vue
@@ -77,16 +77,17 @@ export default {
       // console.log('[Vue Tour] The target element ' + this.step.target + ' of .v-step[id="' + this.hash + '"] is:', targetElement)
 
       if (targetElement) {
-        let jumpOptions = {
-          duration: this.step.duration || 1000,
-          offset: this.step.offset || 0,
-          callback: undefined,
-          a11y: false
+        if (this.params.scroll) {
+          let jumpOptions = {
+            duration: this.step.duration || 1000,
+            offset: this.step.offset || 0,
+            callback: undefined,
+            a11y: false
+          }
+
+          jump(targetElement, jumpOptions)
         }
 
-        jump(targetElement, jumpOptions)
-        // targetElement.scrollIntoView({ behavior: "smooth" })
-
         /* eslint-disable no-new */
         this._data._popper = new Popper(
           targetElement,

diff --git a/src/shared/constants.js b/src/shared/constants.js
@@ -18,6 +18,7 @@ export const DEFAULT_OPTIONS = {
 
 export const DEFAULT_STEP_OPTIONS = {
   placement: 'bottom',
+  scroll: true,
   modifiers: {
     arrow: {
       element: '.v-step__arrow'