Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] remove electrodes from electrodeArray #152

Merged
merged 22 commits into from
Feb 19, 2020

Conversation

DylanLin29
Copy link
Contributor

@DylanLin29 DylanLin29 commented Feb 17, 2020

Description

  • Contributes a method remove_electrode to the ElectrodeArray class (see issue Add a way to remove electrodes from an ElectrodeArray #147)
  • Gets rid of add_electrodes of the ElectrodeArray class, because when electrodes are passed in a dictionary, there is no way to preserve the originally intended order (keys will automatically be sorted). Thus it's safer to call add_electrode in a for loop.

Checklist

@mbeyeler mbeyeler added this to the v0.6 milestone Feb 18, 2020
@mbeyeler mbeyeler merged commit 2a1e151 into pulse2percept:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants