Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] [REF] [DOC] Convert pulse trains to new format #178

Merged
merged 7 commits into from May 1, 2020

Conversation

mbeyeler
Copy link
Member

@mbeyeler mbeyeler commented Apr 30, 2020

  • Convert old pulse trains to new format (see issue Convert pulse trains to new Stimulus format #171)
  • Have all stimuli and pulses use ms as the fundamental time unit (see issue Time should be in milliseconds #170)
  • Move pulses into pulses.py: MonophasicPulse, BiphasicPulse, AsymmetricBiphasicPulse
  • Move pulse trains into pulse_trains.py: BiphasicPulseTrain, AsymmetricBiphasicPulseTrain
  • Fix many edge cases of combining multiple pulse trains into a single Stimulus
  • Mark TimeSeries, PulseTrain as deprecated
  • Update docs: gallery examples, topic on stimuli

@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #178 into master will increase coverage by 1.12%.
The diff coverage is 97.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   87.95%   89.08%   +1.12%     
==========================================
  Files          57       59       +2     
  Lines        4459     4901     +442     
==========================================
+ Hits         3922     4366     +444     
+ Misses        537      535       -2     
Flag Coverage Δ
#unittests 89.08% <97.27%> (+1.12%) ⬆️
Impacted Files Coverage Δ
pulse2percept/models/nanduri2012.py 100.00% <ø> (ø)
pulse2percept/stimuli/pulses.py 90.90% <90.90%> (ø)
pulse2percept/stimuli/pulse_trains.py 92.24% <92.00%> (-3.45%) ⬇️
pulse2percept/stimuli/base.py 97.66% <98.91%> (+0.95%) ⬆️
pulse2percept/stimuli/tests/test_pulses.py 99.53% <99.53%> (ø)
pulse2percept/implants/base.py 94.92% <100.00%> (ø)
pulse2percept/models/base.py 94.93% <100.00%> (+5.06%) ⬆️
pulse2percept/models/tests/test_base.py 98.61% <100.00%> (+0.31%) ⬆️
pulse2percept/models/tests/test_beyeler2019.py 100.00% <100.00%> (ø)
pulse2percept/models/tests/test_nanduri2012.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12af420...4a7f34d. Read the comment docs.

@mbeyeler mbeyeler merged commit 94a7b30 into pulse2percept:master May 1, 2020
@mbeyeler mbeyeler deleted the stim-pulse-trains branch May 1, 2020 17:27
mbeyeler added a commit that referenced this pull request May 1, 2020
* Add new MonophasicPulse, BiphasicPulse, AsymmetricBiphasicPulse

* add merging of time axis, cover many edge cases

* adjust Nanduri model for new time step

* update example gallery and topics-stimuli

* Fix syntax error in code-block

* Disable pdf/epub build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert pulse trains to new Stimulus format Time should be in milliseconds
2 participants