-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add temporal torchmodel #626
base: torch
Are you sure you want to change the base?
Conversation
TODO: add offline fading, implement engine & torch model call from FadingTemporal
ffedb27
to
a8e6ad6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## torch #626 +/- ##
========================================
Coverage ? 91.19%
========================================
Files ? 128
Lines ? 11946
Branches ? 0
========================================
Hits ? 10894
Misses ? 1052
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm a little confused why this is failing right now. Theres an easy fix to the numpy array not being c-contiguous (just copy it with order='c' in predict_percept), but the test where this is failing shouldnt even be running. We pass --benchmark-disable to pytest (pyproject.toml) , and it is skipping most of the other benchmarks, so i'm not sure why its still running this one. Eventually I'll change the workflow to also include benchmarking, but maybe for now we can look into why this test is even being ran? |
Description
Adds torch backend for FadingTemporal,
TorchFadingTemporal
.Refactors the TorchBaseModel
forward
signature to add astate
kwarg for temporal models & to make thee_locs
argument optional in the parent. Subclasses can choose which kwargs to use in theforward
.Type of Change
Please delete options that are not relevant.
Checklist
For detailed information on these and other aspects, see the contribution guidelines: https://pulse2percept.readthedocs.io/en/latest/developers/contributing.html