[ENH] Add generic rectangle implant and remove codecov #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a generic rectangle implant, which has been used previously in multiple papers.
Currently if you want to make a custom implant, you have to make a custom electrode grid, then create a prosthesis system subclass wrapping this earray, which is cumbersome, and lacks some of the basic functions that premade implants have.
This adds a generic
p2p.implants.RectangleImplant
which does all this for the user, so they can have an implant with a custom location, shape, spacing, electrode type, etc with one line.It defaults to the 15x15 implant used in Granley et al 2022 and Granley et al 2023
![image](https://private-user-images.githubusercontent.com/25232557/340043090-11acc64e-f005-4e91-b77a-96e086459a7e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NjIxMzMsIm5iZiI6MTcyMDQ2MTgzMywicGF0aCI6Ii8yNTIzMjU1Ny8zNDAwNDMwOTAtMTFhY2M2NGUtZjAwNS00ZTkxLWI3N2EtOTZlMDg2NDU5YTdlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDE4MDM1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIzOWU2ZjUxNWQ5NTE5N2ViYmJiMDIxZDViZDU5NzhkMTYyMzczYmZkOWE0MGZhYTUwOTE2NzQwNTA5NWY4YTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0eTr0Jb1vu1kl1gdBWicv6ZMtAiUUU0eRFgJSuWO-OM)
This also removes codecov (see #632 )
Type of Change
Please delete options that are not relevant.