Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add generic rectangle implant and remove codecov #631

Merged
merged 6 commits into from
Jun 15, 2024

Conversation

jgranley
Copy link
Member

@jgranley jgranley commented Jun 15, 2024

Description

This adds a generic rectangle implant, which has been used previously in multiple papers.

Currently if you want to make a custom implant, you have to make a custom electrode grid, then create a prosthesis system subclass wrapping this earray, which is cumbersome, and lacks some of the basic functions that premade implants have.

This adds a generic p2p.implants.RectangleImplant which does all this for the user, so they can have an implant with a custom location, shape, spacing, electrode type, etc with one line.

It defaults to the 15x15 implant used in Granley et al 2022 and Granley et al 2023
image

This also removes codecov (see #632 )

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 93.42105% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (7a9da85) to head (bcf8fa6).
Report is 142 commits behind head on master.

Current head bcf8fa6 differs from pull request most recent head b3dbf94

Please upload reports for the commit b3dbf94 to get more accurate results.

Files Patch % Lines
pulse2percept/implants/base.py 83.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   93.83%   88.01%   -5.82%     
==========================================
  Files          90      128      +38     
  Lines        7782    11556    +3774     
==========================================
+ Hits         7302    10171    +2869     
- Misses        480     1385     +905     
Flag Coverage Δ
unittests 88.01% <93.42%> (-5.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgranley jgranley changed the title [ENH] Add generic rectangle implant [ENH] Add generic rectangle implant and remove codecov Jun 15, 2024
@jgranley jgranley merged commit 3f8d5af into pulse2percept:master Jun 15, 2024
23 checks passed
@jgranley jgranley deleted the rect_implant branch June 15, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant