Problems with themes and request

[topoldo]

Dear developer,
I tried to install your plugin into the latest version of roundcube (1.4.8)
I was successfull and it seems to work using with the elastic theme.
BTW I also made the localization into Italian and I can submit it to you if you're interested in.

Anyway, if I check what happens with classic theme, I get what I report in the image below.
Larry theme has similar problems.
Beside, I would like to ask you if it could be make possible to set the warn "outside of your organization" optional or, at least set mails coming from subdomains of a main domain without any warn.
I mean: we have a main domain which is @unipd.it. However we set roundcube for using it with our subdomain, ie @bio.unipd.it. Moreover, inside our University, we have other subdomains like @math.unipd.it, @dei.unipd.it, @stat.unipd.it etc...
It could be userful if your plugin avoid to warn for emails coming from the main domain and from other subdomains if it is not possible to make optional at all the warn for external organization mails.

Regards,
Topoldo

[pulsejet]

Hi

I just tested on a fresh installation of Roundcube 1.4.8 and all three skins seem working fine. Are your sure there's no other plugin which is interfering etc.?

For the external warning, you need to configure the following (note that this has to be done in config.inc.php of the plugin in the plugin directory and NOT the global configuration file)

$config['org_email_regex'] = "/@(.*\.|)unipd\.it/i";

This is a regex match that'll mark all mails from the domain or subdomain as internal.

Would be happy to accept any PR for localization. Thanks!

[topoldo]

Il giorno 23/09/2020 alle 11:41, Varun Patil ha scritto: Hi I just tested on a fresh installation of Roundcube 1.4.8 and all three skins seem working fine. Are your sure there's no other plugin which is interfering etc.? For the external warning, you need to configure the following (note that this has to be done in config.inc.php of the plugin in the plugin directory and NOT the global configuration file) $config['org_email_regex'] = "/@(.*\.|)unipd\.it/i"; This is a regex match that'll mark all mails from the domain or subdomain as internal. Would be happy to accept any PR for localization. Thanks! Thank you for the fast answer and for the tip! About the problem I got: can this due to the fact that I commented out some lines of banner_warn.php in order to completely remove the external site warning? Below there are the lines I commented out: Line 67-69:             // Warn users if mail from outside organization =>            if ($this->addressExternal($message->sender['mailto'])) { =>                array_push($content, '<div class="notice warning">' . $this->gettext('from_outsite') . '</div>'); =>           } and line 140-142: => //        private function addressExternal($address) { => //            return (!preg_match($this->org_mail_regex, $address)); => //        } I tested these modification I made on "elastic" and they were ok. Unfortunately some of my users still use "classic" and "Larry" themes and they reported to me the problem which I also verified (in a second time). Besides, below you find my localization into Italian for your plugins: ***** <?php $labels = array(); $labels['from_outsite'] = "Questo messaggio proviene dall\'esterno della vostra organizzazione. Si consiglia di evitare di fare clic su eventuali link o di aprire allegati a meno che non si conosca il mittente e si ritenga sicuro il contenuto del messaggio"; $labels['posible_spam'] = "Questo messaggio è stato riconosciuto come potenziale SPAM. Si consiglia di essere estremamente cauti nell\'interagire con il relativo contenuto"; $labels['spf_fail'] = "Non è stato possibile verificare l\'autenticità del mittente di questo messaggio.<br>Si consiglia di evitare di fare clic su eventuali link, scaricare allegati o rispondere inviando dati personali"; **** Regards, Topoldo

…

-- Leopoldo Saggin MD PhD Via A. Memmo, 25 35122 PADOVA (PD) - Italy Phone: +39 049 875 2158 (home) Phone: +39 049 827 6016 (office) Email: leopoldo.saggin@yahoo.com Skype: leopoldo.saggin Due cose riempiono la mente con sempre nuova e crescente ammirazione e rispetto, quanto più spesso e più a lungo la riflessione si occupa di esse: il cielo stellato sopra di me e la legge morale in me. Zwei Dinge erfüllen das Gemüt mit immer neuer und zunehmender Bewunderung und Ehrfurcht, je öfter und anhaltender sich das Nachdenken damit beschäftigt: Der bestirnte Himmel über mir und das moralische Gesetz in mir. I. Kant

[topoldo]

Il giorno 23/09/2020 alle 11:41, Varun Patil ha scritto:

Hi I just tested on a fresh installation of Roundcube 1.4.8 and all three skins seem working fine. Are your sure there's no other plugin which is interfering etc.?

I removed the comments and I still have the problem. This is the list of my active plugins: $config['plugins'] = array(     'additional_message_headers',     'advanced_search',     'archive',     'attachment_reminder',     'automatic_addressbook',     'calendar',     'calendar_notifier',     'cloudview',     'contextmenu',     'contextmenu_folder',     'customizr',     'emoticons',     'filesystem_attachments',     'filters',     'folder_info',     'tasklist',     'help',     'hide_blockquote',     'html5_notifier',     'identity_select',     'lastlogin',     'libcalendaring',     'libkolab',     'login_lang',     'markasjunk',     'new_user_dialog',     'newmail_notifier',     'password',     'select_pagesize',     'show_folder_size',     'swipe',     'thunderbird_labels',     'userinfo',     'vcard_attachments',     'zipdownload', );

…

-- Leopoldo Saggin MD PhD Via A. Memmo, 25 35122 PADOVA (PD) - Italy Phone: +39 049 875 2158 (home) Phone: +39 049 827 6016 (office) Email: leopoldo.saggin@yahoo.com Skype: leopoldo.saggin Due cose riempiono la mente con sempre nuova e crescente ammirazione e rispetto, quanto più spesso e più a lungo la riflessione si occupa di esse: il cielo stellato sopra di me e la legge morale in me. Zwei Dinge erfüllen das Gemüt mit immer neuer und zunehmender Bewunderung und Ehrfurcht, je öfter und anhaltender sich das Nachdenken damit beschäftigt: Der bestirnte Himmel über mir und das moralische Gesetz in mir. I. Kant

[topoldo]

I probably understood what was the problem. There is no conflict with other plugins!
The problem was with avatar!
I set
$config['avatar_images'] = true;
But avatar size of is too large to fit the rows of Larry or Classic themes.
This probably was the sense of the other issue raised for this plugin.
So IMHO there should be something in the code which automatically inhibits the use of avatar in Classic and Larry themes, allowing it only if it is set to the elastic one.
Alternatively, there should be different avatars with different sizes which should be to set depending on the theme used.

Thanks for your attention.
Topoldo

[pulsejet]

That's strange. The avatar images are constrained to fit within the container, so they shouldn't be overflowing. I've also tried classic+avatars and larry+avatars and it behaves as expected for me.

[topoldo]

That's strange. The avatar images are constrained to fit within the container, so they shouldn't be overflowing. I've also tried classic+avatars and larry+avatars and it behaves as expected for me.

I checked (= disabled/re-enabled) all the plugins (official and unofficial) I use which I reported in the previous post. The check was performed after re-enabling the native "banner_warn.php" file in order to have the original conditions. In my hands the problem persists. As I wanted to add this extension to roundcube just for my users accessing it from mobile devices in order to simplify to them the selection of mails by means of avatars, I can easily renounce to use this extension. Regards, Topoldo

[pulsejet]

Ahh managed to repro now. The issue occurs when Settings > Mailbox View > Layout is set to Desktop or List instead of 3-column view. Let's see if a fix is possible.

[pulsejet]

Should be fixed in latest release (1.2.7). Also includes the italian localization.

[topoldo]

Fixed!
Tnx
Topoldo