refactor: forcePermissions typing

Signed-off-by: Varun Patil <radialapps@gmail.com>
pulsejet · Oct 22, 2023 · c9e87c4 · c9e87c4
1 parent b3f8387
commit c9e87c4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 19 deletions.
diff --git a/lib/Controller/ImageController.php b/lib/Controller/ImageController.php
@@ -196,7 +196,7 @@ public function info(
             $info['etag'] = $file->getEtag();
 
             // Inject permissions and convert to string
-            $info['permissions'] = \OCA\Memories\Util::permissionsToStr($file->getPermissions());
+            $info['permissions'] = Util::permissionsToStr($file->getPermissions());
 
             // Inject other file parameters that are cheap to get now
             $info['mimetype'] = $file->getMimeType();

diff --git a/lib/Util.php b/lib/Util.php
@@ -186,23 +186,6 @@ public static function isLinkSharingEnabled(): bool
         return true;
     }
 
-    /**
-     * Force a fileinfo value on a node.
-     * This is a hack to avoid subclassing everything.
-     *
-     * @param Node   $node  File to patch
-     * @param string $key   Key to set
-     * @param mixed  $value Value to set
-     */
-    public static function forceFileInfo(Node &$node, string $key, mixed $value): void
-    {
-        /** @var \OC\Files\Node\Node */
-        $node = $node;
-
-        /** @psalm-suppress UndefinedInterfaceMethod */
-        $node->getFileInfo()[$key] = $value;
-    }
-
     /**
      * Force permissions on a node.
      *
@@ -211,7 +194,11 @@ public static function forceFileInfo(Node &$node, string $key, mixed $value): vo
      */
     public static function forcePermissions(Node &$node, int $permissions): void
     {
-        self::forceFileInfo($node, 'permissions', $permissions);
+        /** @var \OC\Files\Node\Node $node */
+        $fileInfo = $node->getFileInfo();
+
+        /** @var \OC\Files\FileInfo $fileInfo */
+        $fileInfo['permissions'] = $permissions;
     }
 
     /**