Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to upload photos directly from the app #69

Closed
Akruidenberg opened this issue Oct 16, 2022 · 23 comments · Fixed by #1078
Closed

Make it possible to upload photos directly from the app #69

Akruidenberg opened this issue Oct 16, 2022 · 23 comments · Fixed by #1078
Labels
feature New feature or request priority: high Higher priority
Milestone

Comments

@Akruidenberg
Copy link

In the upcoming photo app 25, nextcloud get an option to upload photos from the photo app.
It would be nice to have such option in memories also.

@pulsejet pulsejet added the feature New feature or request label Oct 17, 2022
@pulsejet pulsejet added priority: max Highest priority priority: high Higher priority and removed priority: max Highest priority labels Oct 31, 2022
@meichthys
Copy link
Contributor

Along with this, It would also be good to have a way to upload directly to an album like we can do in the default Photos app.

@meichthys
Copy link
Contributor

We may also need to re-index after uploading in order to get the photo to show in the timeline right away(?)

@pulsejet
Copy link
Owner

That happens through a hook anyway; for example if you upload through files or Photos, then it'll index it right away. So the only missing thing is the UI.

@meichthys
Copy link
Contributor

Ok, Nice! Looking forward to it 👍

@major-mayer
Copy link

Does this feature request also cover the case that a shared album does currently not allow uploading new images, even when the mode is set to "editable" ?

@johnSamilin
Copy link
Contributor

Hi everyone, is this feature request still actual?

@meichthys
Copy link
Contributor

Hi @johnSamilin what do you mean "actual"?
It is still relevant if that's what you mean since it has not yet been implemented.

@johnSamilin
Copy link
Contributor

Yep, "relevant" is the word I should have used.
Am I gettings it right? There should be a button somewhere in the interface that opens modal window that allows user to select one or several photos from the device and upload it to nextcloud (and optionally add to one or more albums)?

@meichthys
Copy link
Contributor

meichthys commented Jan 18, 2024

Yes, that's correct. This is one of the few features that NextCloud photos has that NextCloud memories does not have yet.

@johnSamilin
Copy link
Contributor

Feel free to assign this issue to me, I'm planning to start working on it

@johnSamilin
Copy link
Contributor

Where should photos be uploaded to? If I use nextcloud client on android, I may specify whether photos should be uploaded to /year/month folder, should memories also have such setting?

@major-mayer
Copy link

I would say if the user is already in the folders view in Memories, the new photos should be uploaded to the current folder.
This would also work for folders shared with Memories (and maybe even albums, although I have never used them and don't know how they work).
An option to automatically create new subfolders based on year and month would be nice to have, but not a priority for me at least.

Not sure if it would be feasible to add an upload option to the timeline view, since i wouldn't intuitively know where to put the new photos.

@Havouza15
Copy link

Because the upload directly is missing I use Photosync instead on my phone to autotransfer all photos. I have it set to upload it directly when the photo is taken but there is many different options. I really hope this will come also on the Memories app

@johnSamilin
Copy link
Contributor

johnSamilin commented Feb 21, 2024

Hey guys, I'm having troubles with my local nextcloud server and could use some help. Could someone try to build this branch https://github.com/johnSamilin/memories/tree/issue-69.uploading-button and upload a photo (to nextcloud, not here)? I have implemented UI and added integration with backend but seems like I'm stuck with improper server setup.

@major-mayer
Copy link

Maybe @pulsejet could take a look?

pulsejet added a commit that referenced this issue Mar 20, 2024
Signed-off-by: Varun Patil <radialapps@gmail.com>
@ChildLearningClub
Copy link
Sponsor

Great work @johnSamilin and @pulsejet!

@gymnae
Copy link

gymnae commented Mar 21, 2024

That is a great feature. Could that also be enable for publically shared folders and albums on a per share basis?

@ChildLearningClub
Copy link
Sponsor

That is a great feature. Could that also be enable for publically shared folders and albums on a per share basis?

Just asked this same question earlier today #1073

@Joeviocoe
Copy link

I thought this issue was for the mobile app. Guess not. I'm glad to see the direct upload feature working on the web app, but that was already pretty simple to tab over to the Files or Photo apps to upload something.
On the Android app, I have to maintain a completely separate phone app to upload. So I'm patiently waiting for the Android update to include the feature. Hoping soon maybe since the hard part of creating the function server side is done.

@pulsejet
Copy link
Owner

On the Android app, I have to maintain a completely separate phone app to upload.

This is by design and will always be the case; more related to the philosophy of not reinventing the wheel. Auto upload is hard enough that Nextcloud's implementation isn't particularly fantastic. The whole point of using Nextcloud as a base / framework is to not reinvent things like auto upload.

@Joeviocoe
Copy link

Auto upload is hard enough that Nextcloud's implementation isn't particularly fantastic. The whole point of using Nextcloud as a base / framework is to not reinvent things like auto upload.

I'm still confused about what this issue was created for. "Auto upload" refers to watching local folders on your phone and automatically uploading changes (new, modified, deleted files) to Next Cloud, right? Essentially an automatic SYNC feature.
Not the MANUAL OPTION "upload button" that is now available on the web app?

I agree that the local folder "sync" feature should not be included with Memories. But the direct "manual upload" is now a part of Memories at least for desktop browsers. So it should not be too much to have the Android app (which is a wrapper for the web app IIRC) just render that same button and bring up the iOS or Android native file picker using the API.

@pulsejet
Copy link
Owner

Ah yes, I (incorrectly) assumed you misunderstood the issue (haha).

Yes, the android app should also get the manual upload button hopefully soon.

On the Android app, I have to maintain a completely separate phone app to upload.

This is the part that confused me to think you're confused (lmao). You'd still need a separate app anyway for the sync upload.

@Joeviocoe
Copy link

Ah, okay glad that's cleared up. I look forward to the next Android app update for Memories.

You'd still need a separate app anyway for the sync upload.

Not really a feature I need myself, I am fine manually uploading and not syncing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request priority: high Higher priority
Projects
None yet
9 participants